Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [REST-API] Restore possibility to update service/device configuration properties using a "default" value #4128

Merged

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Nov 4, 2024

Right now, if we try to update a service/device configuration property with a value equal to ““ we get an error from the back-end. In an earlier change I broke this behavior and now we want to restore it being able to set a property to the default value

Related Issue
None

Description of the solution adopted
None

Screenshots
None

Any side note on the changes made
None

angelo.andreussi added 2 commits November 4, 2024 14:04
@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.80%. Comparing base (1fe8a81) to head (e7f64da).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4128   +/-   ##
==========================================
  Coverage      16.80%   16.80%           
  Complexity        22       22           
==========================================
  Files           2021     2021           
  Lines          52470    52471    +1     
  Branches        4426     4426           
==========================================
+ Hits            8815     8820    +5     
+ Misses         43257    43253    -4     
  Partials         398      398           
Files with missing lines Coverage Δ
...kapua/model/xml/adapters/XmlPropertiesAdapter.java 95.00% <100.00%> (+0.12%) ⬆️

... and 3 files with indirect coverage changes

@Coduz Coduz merged commit 6639f06 into eclipse-kapua:develop Nov 5, 2024
35 checks passed
@Coduz Coduz deleted the fix-xmlAdaptedPropertiesNullValues branch November 5, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant